fix: newsstand player movement bug + stuck key issue#277
Merged
Conversation
Main Fix: - Fixed player continuing to run after colliding with newsstand - Added immediate velocity reset on collision - Added delay before showing prompt to allow key release - Newsstand now uses showCustomPrompt from utils.js for consistency Bonus Fix: - Added keyup event simulation in closeCustomPrompt to clear stuck keyboard state - Prevents character auto-movement after closing any dialog/interaction - Benefits ALL interactions using showCustomPrompt (newsstand, locker, etc.) Closes zero-to-mastery#276
r4pt0s
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Newsstand player movement bug + stuck key issue
Issues Fixed
Closes #276
Changes Made
Primary Fix: Newsstand Movement Bug
player.vel = k.vec2(0, 0)Bonus Fix: Stuck Key State (Global)
closeCustomPromptto clear stuck keyboard stateshowCustomPrompt(newsstand, locker, etc.)Refactoring
showCustomPromptfrom utils.js for consistencyFiles Changed
src/interactions/map_start/mailboxMainArea.interaction.js- Fixed newsstand collision and movementsrc/utils.js- Added keyup simulation tocloseCustomPromptto prevent stuck keysTesting